Do not fail if phpstan/phpdoc-parser is missing #7279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

VincentLanglet wants to merge 4 commits into api-platform:4.1 from VincentLanglet:docParser

Contributor

VincentLanglet commented Jul 5, 2025 •

edited

Loading

Q	A
Branch?	4.1
Tickets	Closes #7275
License	MIT
Doc PR	api-platform/docs#...

Not fully sure about this one @soyuka but

I assume the issue Laravel: Updating from 4.1.17 to 4.1.18 fails — Class PHPStan\PhpDocParser\Parser\TokenIterator not found #7275 is related to https://github.com/api-platform/core/pull/7204/files#diff-a74b749ab4aa559ca58d9087c4f2c9193ca78bc87ac65ab9a6a09f2d8b799581 which does not require phpstan/doc-parser since 4.18.
Lot of PHPStan\PhpDocParser classes are used in PhpDocResourceMetadataCollectionFactory. (like

core/src/Metadata/Resource/Factory/PhpDocResourceMetadataCollectionFactory.php

Line 141 in d3b98b5

$tokens = new TokenIterator($this->lexer->tokenize($rawDocNode));

)

So since phpDocParser/lexer will be null when PhpDocParser is not installed, a null check might be enough.


          fix: require phpstan/phpdoc-parser

6562cc3

VincentLanglet force-pushed the docParser branch from beed356 to 6562cc3 Compare

July 5, 2025 22:29


          fix: avoid extra dependencies

7bf189f

VincentLanglet changed the title ~~Require phpstan/phpdoc-parser~~ Do not fail if phpstan/phpdoc-parser is missing


          fix: check property

c44438b

Contributor Author

VincentLanglet commented Jul 5, 2025

@PicassoHouessou could you try this branch ? Does it solve your issue ?

PicassoHouessou commented Jul 5, 2025

Hello @VincentLanglet. It solves my issue.


          fix: earlier return

8e6f0bf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet