[pyupgrade
] Fix UP007
: ignore Optional[NamedTuple]
#18682
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make
UP007
/UP045
ignoreOptional[NamedTuple]
asNamedTuple
is a function (not a proper type). Rewriting it toNamedTuple | None
breaks at runtime. While type checkers currently acceptNamedTuple
as a type, they arguably shouldn't. Therefore, we outright ignore it and don't touch or lint on it.For a more detailed discussion, see the linked issue.
Test Plan
Added examples to the existing tests.
Related Issues
Fixes: #18619