Skip to content

[flake8-comprehension] Mark autofix for C420 as unsafe if there's comments inside the dict comprehension #18768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2025

Conversation

LaBatata101
Copy link
Contributor

Summary

Fixes #18764

Test Plan

Add regression test

Copy link
Contributor

github-actions bot commented Jun 18, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser MichaReiser added the fixes Related to suggested fixes for violations label Jun 19, 2025
@MichaReiser MichaReiser reopened this Jun 19, 2025
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@MichaReiser MichaReiser enabled auto-merge (squash) June 19, 2025 09:40
@MichaReiser MichaReiser merged commit 65b288b into astral-sh:main Jun 19, 2025
67 of 68 checks passed
@LaBatata101 LaBatata101 deleted the fix-C420 branch June 19, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixes Related to suggested fixes for violations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C420 fix should be marked unsafe for comment deletion
2 participants