Speed up a couple of tests #5799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
There was a problem hiding this comment.
Pull Request Overview
This PR aims to speed up tests by switching several test classes from using BeetsTestCase to the lighter weight unittest.TestCase in cases where the filesystem setup/teardown is unnecessary.
- Remove unnecessary BeetsTestCase imports from multiple test files
- Update test class inheritance to use unittest.TestCase
- Adjust test configuration in pyproject.toml for coverage collection
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/test_util.py | Replaced BeetsTestCase with unittest.TestCase for utility tests |
| test/test_ui.py | Updated test classes to inherit from unittest.TestCase |
| test/test_sort.py | Changed CaseSensitivityTest to inherit from DummyDataTestCase and unittest.TestCase |
| test/test_query.py | Replaced BeetsTestCase with unittest.TestCase in query-related tests |
| test/test_logging.py | Modified LoggingTest to inherit from unittest.TestCase, removing extra BeetsTestCase import |
| test/test_importer.py | Updated test classes to use unittest.TestCase |
| test/test_files.py | Changed HelperTest to use unittest.TestCase |
| test/plugins/* | Updated various plugin tests to replace BeetsTestCase with unittest.TestCase |
| pyproject.toml | Adjusted the coverage flags configuration |
Comments suppressed due to low confidence (2)
pyproject.toml:223
- Verify that the removal of duplicate coverage flags (for both beets and beetsplug) is intentional and that the current setup still collects coverage for all required modules.
---cov=beets
test/test_sort.py:383
- Double-check that combining DummyDataTestCase with unittest.TestCase provides all necessary initialization, since the removal of BeetsTestCase might remove expected setup steps.
class CaseSensitivityTest(DummyDataTestCase, unittest.TestCase):
snejus
force-pushed
the
speed-up-some-tests
branch
from
94d60b7 to
6fa0676
Compare
semohr
approved these changes
May 26, 2025
Of course! Using $ git checkout speed-up-some-tests
$ classes=($(git diff master.. -U0 | grep -E '[A-Za-z]+Test\b' -o | sort -u))
$ poe test -k ${(j: or :)classes} | grep -e Poe -e passed
$ Poe => pytest -p no:cov -k 'ArtistFlatteningTest or BeatportResponseEmptyTest or CaseSensitivityTest or CommonOptionsParserTest or DeprecatedConfigTest or EncodingTest or EnforceRatioConfigTest or HelperTest or InferAlbumDataTest or LastGenrePluginTest or LoggingTest or MatchTest or NotQueryMatchTest or PathConversionTest or PathFormatTest or SubsonicPluginTest or SummarizeItemsTest or TagLogTest or ThePluginTest'
==== 102 passed, 1860 deselected in 18.56s ====
$ git checkout master
$ poe test -k ${(j: or :)classes} | grep -e Poe -e passed
$ Poe => pytest -p no:cov -k 'ArtistFlatteningTest or BeatportResponseEmptyTest or CaseSensitivityTest or CommonOptionsParserTest or DeprecatedConfigTest or EncodingTest or EnforceRatioConfigTest or HelperTest or InferAlbumDataTest or LastGenrePluginTest or LoggingTest or MatchTest or NotQueryMatchTest or PathConversionTest or PathFormatTest or SubsonicPluginTest or SummarizeItemsTest or TagLogTest or ThePluginTest'
==== 102 passed, 1860 deselected in 22.96s ====Not a huge difference, actually, since this only affects 102 tests. Just had a look at specific test durations: this branch
|
snejus
force-pushed
the
speed-up-some-tests
branch
from
6fa0676 to
5900282
Compare
|
Lastgenre tests do depend on the configuration made available by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speed up tests by using
unittest.TestCasefor tests that don't require directory setupThis PR improves test performance by switching several test classes from
BeetsTestCaseto standardunittest.TestCasewhen they don't require the directory setup and teardown overhead. The changes focus on test classes that:The PR removes unnecessary imports of
BeetsTestCaseand adds direct imports ofunittestwhere needed. This change reduces the test execution time by avoiding the expensive setup/teardown steps for tests that don't require them.