-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[docs] remove old contact info (#5462) #5807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes outdated mailing list references and streamlines installation instructions across the documentation to reflect current support channels and Python requirements.
- Remove all references to the old mailing list.
- Bump Python requirement to 3.9+, add pip/package manager instructions, and prune obsolete setup steps.
- Add a changelog entry for this change (fixes Old contact info in the docs #5462).
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
docs/index.rst | Removed mailing list links and updated help channels |
docs/guides/tagger.rst | Removed mailing list anchor |
docs/guides/main.rst | Updated installation guide: require Python 3.9+, added pip/package manager steps |
docs/faq.rst | Removed mailing list anchor and trimmed bug-reporting instructions |
docs/changelog.rst | Added entry for removed contact info (PR #5462) |
Comments suppressed due to low confidence (1)
docs/changelog.rst:34
- The new changelog entry isn't indented to match the other bullet items under "Bug fixes:" (should have two spaces before
*
).
* removed old contact info in docs
pip install --user beets | ||
|
||
|
||
.. attention:: Python 3.13 not officially supported yet! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you reckon this is needed?
I'm just mindful that we will need to remember to remove it once we support 3.13, and I have no clue how to make sure this happens 🤣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can't be sure which python versions are installed on a user device. By default the python download page now suggests you install 3.13. So having a note here is kinda necessary to prevent issues for new users.
I guess this note is predominant enough to not miss is in the update ;). We will see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we instead just update our supported python version in pyproject.toml
?
Currently it supports 3.13
apparently
[tool.poetry.dependencies]
python = ">=3.9,<4"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, I wasn't clear. I meant we should update the python version requirement
[tool.poetry.dependencies]
python = ">=3.9,<3.13"
this would ensure that beets
is not installable on 3.13.1 afaik.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As part of my testing on Arch it was running 3.13 and it seemed to pull in the packages mentioned in #5798.
I'll need to check again after work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to remove the 3.13 note from the docs if you'd prefer 🤷
That said, put yourself in the shoes of a new user: just installed Python to try out beets, only to find out 3.13 isn’t supported and there’s no mention of it in the docs. That would be a bit frustrating, having to reinstall python.
b47ba60
to
1b645c9
Compare
- macport: stuck on 1.6 - slackware: stuck on 1.6 - OpenBSD: stuck on 1.6 Remove twitter reference. Removed mailing list reference.
1b645c9
to
4d68b36
Compare
Description
Fixes #5462