Skip to content

Vectorize PNG artwork #2990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2025
Merged

Vectorize PNG artwork #2990

merged 1 commit into from
Jun 21, 2025

Conversation

localspook
Copy link
Contributor

The logo in the README is pretty pixelated, so this PR vectorizes it (and the rest of the artwork). The files are Inkscape SVGs.

I renamed catch2-logo-small*.png to catch2-logo-full*.svg because vector images don't really have an inherent size.

@localspook
Copy link
Contributor Author

CI failure seems unrelated...

CMake Error at C:/Program Files (x86)/CMake/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:146 (message):
  Could NOT find PythonInterp: Found unsuitable version "2.7.17", but
  required is at least "3" (found C:/Python27/python.exe)

@ChrisThrasher
Copy link
Collaborator

Can I ask how you vectorized these files?

@localspook
Copy link
Contributor Author

Inkscape’s Trace Bitmap tool to start, then manual fixups for parts the tool didn’t do a good job on.

@ChrisThrasher
Copy link
Collaborator

ChrisThrasher commented Jun 15, 2025

Please rebase on the devel branch. It should fix CI. I would do this myself but I'm not allowed to because you opened the PR from your fork's trunk branch.

@localspook
Copy link
Contributor Author

Rebased. I didn't know opening from trunk had that kind of restriction, I'll be more careful to create new branches in the future.

Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.98%. Comparing base (416b075) to head (12b698b).
Report is 1 commits behind head on devel.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #2990   +/-   ##
=======================================
  Coverage   90.98%   90.98%           
=======================================
  Files         198      198           
  Lines        8599     8599           
=======================================
  Hits         7823     7823           
  Misses        776      776           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ChrisThrasher
Copy link
Collaborator

Thanks!

@ChrisThrasher ChrisThrasher merged commit 04cbcfa into catchorg:devel Jun 21, 2025
92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants