feat: debug_ensure{,_eq,_ne} macros combining debug_assert* and anyhow::ensure (#6907) #6922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iequidoo
force-pushed
the
iequidoo/debug_ensure
branch
from
1deedb1 to
6362989
Compare
iequidoo
force-pushed
the
iequidoo/debug_ensure
branch
from
6362989 to
3b165d1
Compare
link2xt
force-pushed
the
main
branch
2 times, most recently
from
285d80a to
416131b
Compare
iequidoo
force-pushed
the
iequidoo/debug_ensure
branch
from
3b165d1 to
a6f850e
Compare
…w::ensure (#6907) We have some debug assertions already, but we also want the corresponding errors in the release configuration so that it's not less reliable than non-optimized one. This doesn't change any function signatures, only debug assertions in functions returning `Result` are replaced.
iequidoo
force-pushed
the
iequidoo/debug_ensure
branch
from
a6f850e to
3dec58b
Compare
|
I don't like the naming, for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.
Still sometimes we don't want to error out in the release conf if the error isn't critical (in which case it's better to log a warning as @Hocuri suggested in #6907). Need to recheck all assertions and create a follow-up PR.