Added Emscripten examples #184
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added game image
memsharded
reviewed
Jun 2, 2025
This was referenced Jun 4, 2025
memsharded
reviewed
Jun 9, 2025
| tools.build:sharedlinkflags=['-sALLOW_MEMORY_GROWTH=1'] | ||
|
|
||
| # Set Ninja as default generator as it is faster and will sove issues on Windows | ||
| tools.cmake.cmaketoolchain:generator=Ninja |
There was a problem hiding this comment.
What is the default generator for emcc? Unix/MinGW Makefiles?
| @@ -0,0 +1,39 @@ | |||
| # Note: this profile uses emsdk package from Conan Center Index | |||
There was a problem hiding this comment.
Call this profile emcc_base or something like that?
| deps.generate() | ||
|
|
||
| tc = CMakeToolchain(self) | ||
| tc.extra_exelinkflags.append( |
There was a problem hiding this comment.
Same as above, either a validate() or the flags go to the profile?
memsharded
added a commit
to conan-io/conan
that referenced
this pull request
Jun 12, 2025
… + emcc) (#18432) Changelog: Feature: Added first class citizen emscripten support (new wasm64 architecture + emcc) Docs: conan-io/docs#4115 Examples2: conan-io/examples2#184 This PR adds updated support to `wasm` (32 bits) and `asm.js` and introduces new architecture `wasm64`.
czoido
reviewed
Jun 30, 2025
.github/workflows/ros-tests.yml
Outdated
Comment on lines
21
to
24
| # - name: Update ROS signing key (per ROS migration guide) | ||
| # run: | | ||
| # sudo rm /usr/share/keyrings/ros2-latest-archive-keyring.gpg | ||
| # sudo curl -sSL https://raw.githubusercontent.com/ros/rosdistro/master/ros.key -o /usr/share/keyrings/ros2-latest-archive-keyring.gpg |
There was a problem hiding this comment.
Isn't this necessary any more? Why is this commented?
czoido
reviewed
Jul 3, 2025
.github/workflows/ros-tests.yml
Outdated
| run: | | ||
| sudo rm /usr/share/keyrings/ros2-latest-archive-keyring.gpg | ||
| sudo curl -sSL https://raw.githubusercontent.com/ros/rosdistro/master/ros.key -o /usr/share/keyrings/ros2-latest-archive-keyring.gpg | ||
| # - name: Update ROS signing key (per ROS migration guide) |
There was a problem hiding this comment.
this was already fixed in main branch, could you sync your branch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.