Skip to content

Quadlet - fix dropin overwrites if different parent dirs #26557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eulores
Copy link
Contributor

@eulores eulores commented Jul 2, 2025

fixes #26555

Does this PR introduce a user-facing change?

None

fixes containers#26555

Signed-off-by: Andreas <43118918+eulores@users.noreply.github.com>
Copy link
Contributor

openshift-ci bot commented Jul 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eulores
Once this PR has been reviewed and has the lgtm label, please assign mtrmac for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think a test case would be good so we don't regress in the future.
I don't see any existing tests that could extended for this @ygalblum do you have a idea what would be the best way to check this?I guess some new unit tests for loadUnitDropins() is needed?

@ygalblum
Copy link
Contributor

ygalblum commented Jul 2, 2025

Maybe add it as part of the system test:

@test "quadlet - drop-in files" {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quadlets: Wrong .conf drop-in overwrites, if located in different subdirectories
3 participants