fix: hydration issues, missing routes #1125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR addresses hydration errors by refining the skeleton layout and ensures new LlamaLend routes are registered in both the app and end-to-end tests.
- Add
llamalendto route patterns and test support utilities - Adjust
PageLlamaMarketslayout to avoid hydration mismatches - Introduce new dynamic routes for integrations and disclaimer pages
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/cypress/support/ui.ts | Added llamalend to allowed app paths for UI helpers |
| tests/cypress/e2e/llamalend/llamalend-markets.cy.ts | Switched import to package dist build of GetMarketsResponse |
| packages/eslint-config-custom/index.js | Annotated map callback keys with inline comments |
| packages/curve-ui-kit/src/themes/design/1_sizes_spaces.ts | Introduced new pageContent min-height token |
| apps/main/src/llamalend/llamalend.types.ts | Defined NetworkEnum and NetworkUrlParams types |
| apps/main/src/llamalend/PageLlamaMarkets/Page.tsx | Updated skeleton wrapper to use Stack and MinHeight.pageContent |
| apps/main/src/llamalend/PageLlamaMarkets/MarketsFilterChips.tsx | Refined connection check for market filter chips |
| apps/main/src/llamalend/PageLlamaMarkets/LlamaMarketsTable.tsx | Guard filtered row model usage and adjust hidden count guard |
| apps/main/src/app/llamalend/[network]/integrations/page.tsx | Added dynamic integrations page |
| apps/main/src/app/llamalend/[network]/disclaimer/page.tsx | Added dynamic disclaimer page |
Comments suppressed due to low confidence (3)
apps/main/src/llamalend/llamalend.types.ts:3
- [nitpick] The type
NetworkEnumis actually a string union rather than a true enum; consider renaming it toNetworkNamefor clarity.
export type NetworkEnum = INetworkName
apps/main/src/app/llamalend/[network]/integrations/page.tsx:2
- [nitpick] Consider adding a proper JIRA/ticket reference or creating a follow-up task rather than a generic
// todocomment to track this refactor.
// todo: we import the lend integrations page for now, we should refactor the integrations page to be shared between all apps
apps/main/src/app/llamalend/[network]/disclaimer/page.tsx:4
- New disclaimer and integrations pages have been added—ensure end-to-end tests cover navigation to these routes for both happy paths and error states.
import { Disclaimer } from '@ui-kit/widgets/Disclaimer'
mimaklas
approved these changes
Jul 4, 2025
0xAlunara
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In production: https://react.dev/errors/418?args[]=text&args[]=
In development:
