Skip to content

Decrease retry log level #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 23, 2025
Merged

Decrease retry log level #27

merged 3 commits into from
Jun 23, 2025

Conversation

TheForbiddenAi
Copy link

@TheForbiddenAi TheForbiddenAi commented Jun 12, 2025

Issue describing the changes in this PR

resolves #1421

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes are added to the CHANGELOG.md
  • I have added all required tests (Unit tests, E2E tests)

Signed-off-by: Mason <theforbiddenai@gmail.com>
Signed-off-by: Mason <theforbiddenai@gmail.com>
Copy link

@siri-varma siri-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you

@siri-varma
Copy link

@cicoyle / @artur-ciocanu Please take a look at this PR once you get a chance. Thank you.

@TheForbiddenAi
Copy link
Author

Hold off on merging/approving this for a little bit. I want to see if it's possible to log only when it is not replaying. This would prevent log spam if possible.

Signed-off-by: Mason <theforbiddenai@gmail.com>
@TheForbiddenAi
Copy link
Author

TheForbiddenAi commented Jun 17, 2025

Changed to only log when not replaying. This means it will only log the current attempt. Right now, it logs the current attempt and all previous attempts for each retry.

For example, if I have a log that says "Test". Before this change, on the first attempt it would log it once, the second twice, the third three times, and so on. With this change, it will only log it once for each attempt.

@cicoyle cicoyle merged commit 5a579db into dapr:main Jun 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decrease retry log level in durable task
3 participants