Improve GrpcWorker shutdown #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier Aliaga <javier@diagrid.io>
javier-aliaga
commented
Jun 19, 2025
| */ | ||
| public void start() { | ||
| new Thread(this::startAndBlock).start(); | ||
| this.workerThread = new Thread(this::startAndBlock); | ||
| this.workerThread.start(); |
javier-aliaga
commented
Jun 19, 2025
| @@ -39,6 +40,7 @@ public final class DurableTaskGrpcWorker implements AutoCloseable { | |||
| private final TaskHubSidecarServiceBlockingStub sidecarClient; | |||
| private final boolean isExecutorServiceManaged; | |||
| private volatile boolean isNormalShutdown = false; | |||
| private Thread workerThread; | |||
javier-aliaga
commented
Jun 19, 2025
| * it is the responsibility of the supplier to take care of them. | ||
| */ | ||
| public void close() { | ||
| this.workerThread.interrupt(); |
Signed-off-by: Javier Aliaga <javier@diagrid.io>
javier-aliaga
force-pushed
the
fix-startAndBlock
branch
from
ef61c25 to
d911e00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves previous
TODOInterrupt worker thread on stop
Pull request checklist
CHANGELOG.mdAdditional information
Additional PR information