Skip to content

fix(docs): import #4409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 25, 2025
Merged

fix(docs): import #4409

merged 4 commits into from
Jun 25, 2025

Conversation

mfranzke
Copy link
Collaborator

Proposed changes

The other import is most likely incorrect and needs to get replaced

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

the other import is most likely incorrect and needs to get replaced
@mfranzke mfranzke requested a review from nmerget as a code owner June 25, 2025 09:27
@mfranzke mfranzke added 🐛bug Something isn't working 📕documentation Improvements or additions to documentation labels Jun 25, 2025
@mfranzke mfranzke moved this to 👀 In review in UX Engineering Team Backlog Jun 25, 2025
@mfranzke mfranzke requested review from Copilot and removed request for nmerget June 25, 2025 09:27
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects the imported directive name in the Angular documentation for the header component, replacing an incorrect import with the intended one.

  • Replaces ActionBarDirective with SecondaryActionDirective in the docs.
  • Aligns docs import statement with actual code API.
Comments suppressed due to low confidence (1)

packages/components/src/components/header/docs/Angular.md:12

  • Ensure that any usage examples or mentions of ActionBarDirective elsewhere in this document are also updated to SecondaryActionDirective to keep the documentation consistent.
	SecondaryActionDirective,

@mfranzke mfranzke enabled auto-merge (squash) June 25, 2025 09:27
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/fix-docs-import

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mfranzke mfranzke merged commit b27f877 into main Jun 25, 2025
75 checks passed
@mfranzke mfranzke deleted the fix-docs-import branch June 25, 2025 13:50
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in UX Engineering Team Backlog Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working 📕documentation Improvements or additions to documentation
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants