-
-
Notifications
You must be signed in to change notification settings - Fork 15
Switch to Github Actions #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It seems Github Actions isn't activated here? I ran it on my own fork and it seems to work as expected: Windvis#1 |
so @Windvis the difference here is that AppVeyor is used to test Windows 🤔 there is a github windows OS but we need to make sure that things are working before we swap this over Are you able to add windows to the github CI and see what happens? |
Ah, I didn't know that. I left out that part, but can add it 👍 I wanted to do that in a follow up PR 😄 |
d1eaf72
to
8694545
Compare
@mansona It seems |
lol I was just writing a reply and you beat me to it 😂 no we never did any mac testing on here so it's safe to remove it 👍 |
@mansona The linter seems to be failing on Windows: https://github.com/Windvis/ember-cli-blueprint-test-helpers/actions/runs/12253529170/job/34182447934?pr=1 Something seems to be converting the line breaks to
I'm not sure where that conversion happens though. Can I just disable that lint rule? We'll replace it with Prettier soon anyway? Or should I try to find where the conversion happens and see if I can prevent that? Edit: looks like this might be the cause: actions/checkout#135 but not sure if using one of the listed workarounds is preferred over disabling the lint rule. |
just delete that eslint rule, it's silly and it doesn't match what we're doing in other repos these days |
This makes the setup more consistent with the other Ember repos.
This rule fails on Windows in CI due to the way the git is configured by default. Instead of finding a workaround we disable the rule since it's won't be part of a modern eslint setup anyways.
8694545
to
fe9af91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice one 🎉
This makes the setup more consistent with the other Ember repos.
I left the .travis.yml file for now since it seems to be used for releases which we will most likely replace with release-plan later.