Update tests kindergarten garden #2690
Conversation
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
| ]); | ||
| }); | ||
| describe('Kindergarten Garden', () => { | ||
| describe('partial Garden', () => { |
There was a problem hiding this comment.
Nested describe blocks aren't supported currently.
There was a problem hiding this comment.
But exercises like high-scores, forth, and several others already use nested describe blocks. Am I missing something here?
Is the concern about the depth of nesting, like these having only two levels, while this has three? Just trying to understand if that’s the distinction you’re referring to.
There was a problem hiding this comment.
It's an old format that we no longer support.
Recently this broke freelance-rates (see #2686) so I'd like to avoid such cases in the future.
It's not that it's illegal to write nested describe blocks, jest allows it, but the current iteration of our test runner is unhappy with this kind of thing, so we specifically request one describe block per group of tests.
There was a problem hiding this comment.
Sure, that makes sense!
I’ll make sure to avoid using nested describe blocks if I come across them in the future. And make changes in this one!
Pull Request
This PR syncs
tests.tomlwith theproblem-specificationsrepository and updates the test file.