-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
Add CONTRIBUTING.md and CODE_OF_CONDUCT.md files #6604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I have added the contributing.d and code_of_conduct.md |
The links should be updated like @ShubhamOulkar did in #6601 and point to files from expressjs/.github repository (see #6593 (comment)). Additionally, the link to the Code of Conduct is given at the bottom of README and that's where it should be changed (it's a collapsed reference link): Line 272 in 98c85eb
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have made changes . and added the code of conduct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the PR focused, this change is unnecessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better if you created a new PR, since this change could block the goal of the current one, which is to bring that file back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content of this file should say something like "The code of conduct is located in https://github.com/expressjs/.github/blob/HEAD/CODE_OF_CONDUCT.md" rather than bringing back the full content, since we don’t want to maintain two versions in different places.
No description provided.