Skip to content

Add CONTRIBUTING.md and CODE_OF_CONDUCT.md files #6604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

RaginiSharma01
Copy link

No description provided.

@RaginiSharma01
Copy link
Author

I have added the contributing.d and code_of_conduct.md

@krzysdz
Copy link
Contributor

krzysdz commented Jun 28, 2025

The links should be updated like @ShubhamOulkar did in #6601 and point to files from expressjs/.github repository (see #6593 (comment)). Additionally, the link to the Code of Conduct is given at the bottom of README and that's where it should be changed (it's a collapsed reference link):

[Code of Conduct]: https://github.com/expressjs/express/blob/master/Code-Of-Conduct.md

Copy link
Author

@RaginiSharma01 RaginiSharma01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have made changes . and added the code of conduct

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the PR focused, this change is unnecessary

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if you created a new PR, since this change could block the goal of the current one, which is to bring that file back.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content of this file should say something like "The code of conduct is located in https://github.com/expressjs/.github/blob/HEAD/CODE_OF_CONDUCT.md" rather than bringing back the full content, since we don’t want to maintain two versions in different places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants