Skip to content

[react-native] Consume ReactNativeAttributePayloadFabric from ReactNativePrivateInterface #33616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025

Conversation

javache
Copy link
Member

@javache javache commented Jun 23, 2025

Summary

ReactNativeAttributePayloadFabric was synced to react-native in facebook/react-native@0e42d33. We should now consume these methods from the ReactNativePrivateInterface.

Moving these methods to the React Native repo gives us more flexibility to experiment with new techniques for bridging and diffing props payloads.

I did have to leave some stub implementations for existing unit tests, but moved all detailed tests to the React Native repo.

How did you test this change?

  • yarn prettier
  • yarn test ReactFabric-test

@react-sizebot
Copy link

react-sizebot commented Jun 23, 2025

Comparing: 18ee505...3d41f9b

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.11% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.57 kB 530.57 kB = 93.67 kB 93.67 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 651.66 kB 651.66 kB = 114.78 kB 114.78 kB
facebook-www/ReactDOM-prod.classic.js = 674.81 kB 674.81 kB = 118.78 kB 118.78 kB
facebook-www/ReactDOM-prod.modern.js = 665.30 kB 665.30 kB = 117.19 kB 117.19 kB
react-native/implementations/ReactFabric-profiling.js = 393.91 kB 385.80 kB = 67.11 kB 65.75 kB
react-native/implementations/ReactFabric-prod.fb.js = 386.99 kB 378.96 kB = 66.86 kB 65.53 kB
react-native/implementations/ReactFabric-prod.js = 365.86 kB 357.79 kB = 63.10 kB 61.77 kB
react-native/shims/ReactNativeTypes.js = 7.23 kB 7.04 kB = 1.97 kB 1.96 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
react-native/implementations/ReactFabric-dev.fb.js = 734.08 kB 724.97 kB = 116.58 kB 115.09 kB
react-native/implementations/ReactFabric-dev.js = 654.00 kB 644.88 kB = 106.03 kB 104.62 kB
react-native/implementations/ReactFabric-profiling.fb.js = 454.59 kB 446.57 kB = 75.80 kB 74.48 kB
react-native/implementations/ReactFabric-profiling.js = 393.91 kB 385.80 kB = 67.11 kB 65.75 kB
react-native/implementations/ReactFabric-prod.fb.js = 386.99 kB 378.96 kB = 66.86 kB 65.53 kB
react-native/implementations/ReactFabric-prod.js = 365.86 kB 357.79 kB = 63.10 kB 61.77 kB
react-native/shims/ReactNativeTypes.js = 7.23 kB 7.04 kB = 1.97 kB 1.96 kB

Generated by 🚫 dangerJS against 3d41f9b

@javache javache force-pushed the react_native_attribute_payload branch from c149d86 to 3d41f9b Compare June 23, 2025 13:41
@javache javache merged commit 7a3ffef into facebook:main Jun 25, 2025
241 checks passed
@javache javache deleted the react_native_attribute_payload branch June 25, 2025 09:23
github-actions bot pushed a commit that referenced this pull request Jun 25, 2025
…tivePrivateInterface (#33616)

## Summary

ReactNativeAttributePayloadFabric was synced to react-native in
facebook/react-native@0e42d33.
We should now consume these methods from the
ReactNativePrivateInterface.

Moving these methods to the React Native repo gives us more flexibility
to experiment with new techniques for bridging and diffing props
payloads.

I did have to leave some stub implementations for existing unit tests,
but moved all detailed tests to the React Native repo.

## How did you test this change?

* `yarn prettier`
* `yarn test ReactFabric-test`

DiffTrain build for [7a3ffef](7a3ffef)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants