Skip to content

Align AttributeConfiguration type in ReactNativeTypes #33671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025

Conversation

coado
Copy link
Contributor

@coado coado commented Jun 30, 2025

Summary

This PR aligns AttributeConfiguration in ReactNativeTypes to generate proper TS definitions using flow-api-translator. Currently, the generated TS type produces ts error due to mismatch in style and object indexer type:

Screenshot 2025-06-30 at 15 06 18

How did you test this change?

Changed in react-native repo and regenerated the snapshot.

@react-sizebot
Copy link

Comparing: 3cfcdfb...cde29e9

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.57 kB 530.57 kB = 93.67 kB 93.67 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 651.66 kB 651.66 kB = 114.78 kB 114.78 kB
facebook-www/ReactDOM-prod.classic.js = 674.81 kB 674.81 kB = 118.78 kB 118.78 kB
facebook-www/ReactDOM-prod.modern.js = 665.30 kB 665.30 kB = 117.19 kB 117.19 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against cde29e9

@facebook-github-bot
Copy link
Contributor

@huntie has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link

@hardanishsingh1 hardanishsingh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@huntie
Copy link
Member

huntie commented Jun 30, 2025

Hmm, there's both an import and a merge option on this PR, which is new to me 😅. @hoxyq What do I do? 😄

@hoxyq
Copy link
Contributor

hoxyq commented Jun 30, 2025

Hmm, there's both an import and a merge option on this PR, which is new to me 😅. @hoxyq What do I do? 😄

You squash and merge it from GH, then it will be synced locally.

@huntie huntie merged commit 1e0d12b into facebook:main Jun 30, 2025
249 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants