More accurate spotless config #4499
Conversation
runningcode
requested review from
adinauer,
romtsn,
stefanosiano,
markushi and
lcian
as code owners
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
| id("com.diffplug.spotless") | ||
| } | ||
|
|
||
| spotless { |
There was a problem hiding this comment.
This is the new logic.
| targetExclude("src/test/java/io/sentry/apollo4/generated/**", "src/test/java/io/sentry/apollo3/adapter/**") | ||
| suppressLintsFor { | ||
| step = "ktlint" | ||
| shortCode = "standard:max-line-length" |
There was a problem hiding this comment.
max-line-length, property-naming and function-naming had hundreds of violations that aren’t auto-fixable and would have made this PR even larger so i just supressed them for now.
runningcode
changed the title
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 266364c | 387.39 ms | 420.94 ms | 33.55 ms |
| 6c80c41 | 453.08 ms | 472.14 ms | 19.06 ms |
| 3aa20d2 | 429.21 ms | 513.43 ms | 84.21 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 266364c | 1.58 MiB | 2.09 MiB | 518.66 KiB |
| 6c80c41 | 1.58 MiB | 2.09 MiB | 518.71 KiB |
| 3aa20d2 | 1.58 MiB | 2.09 MiB | 518.66 KiB |
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
This PR ensures that spotless is actually running over all our files. It wasn't before and you can see this generated a massive diff. There are still a number of exceptions that were suppressed in order to save time going through the hundreds of them. In other news, this moves the spotless logic to its own convention plugin and runs over each source set of each project separately. This means that most of the tasks should be cached independently.
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
📜 Description
This PR ensures that spotless is actually running over all our files. It
wasn't before and you can see this generated a massive diff.
There are still a number of exceptions that were suppressed in order to
save time going through the hundreds of them.
In other news, this moves the spotless logic to its own convention
plugin and runs over each source set of each project separately. This
means that most of the tasks should be cached independently.
This switches our formatter to ktfmt and 2 space indents to match the SAGP codebase.
#skip-changelog
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps