Skip to content

fix: issue 1641 database session service leaks events #1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: issue 1641 database session service leaks events #1644

wants to merge 1 commit into from
+13 −0

Conversation

sindrigunnars
Copy link

fix: issue 1641 database session service leaks events

@sindrigunnars sindrigunnars mentioned this pull request Jun 25, 2025
Open
@hangfei hangfei requested a review from DeanChensj June 25, 2025 22:23
DeanChensj
DeanChensj approved these changes Jun 26, 2025
View reviewed changes
Copy link
Collaborator

@DeanChensj DeanChensj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we run auto_format.sh to resolve the error?

@DeanChensj
Copy link
Collaborator

Could you fix:

This pull request has 7 commits.
Please squash them into a single commit before merging.
You can use git rebase -i HEAD~N
...where N is the number of commits you want to squash together. The PR check conveniently tells you this number! For example, if the check says you have 3 commits, you would run: git rebase -i HEAD~3.
Because you have rewritten the commit history, you must use the --force flag to update the pull request: git push --force

@sindrigunnars
fix: scenario where a user can access another users events given the …
d1b2e06 
…same session id

test: refine test_session_state in test_session_state to catch event leakage

fix: revert app name to my_app for test_session_state test

style: fix pyink style warnings
@sindrigunnars sindrigunnars force-pushed the fix-issue-1641-database-session-service branch from dcb086a to d1b2e06 Compare June 27, 2025 18:55
@sindrigunnars
Copy link
Author

Should be good now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeanChensj DeanChensj DeanChensj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sindrigunnars @DeanChensj