-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat(auth): add support for fullName when using Sign in with Apple #8570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(auth): add support for fullName when using Sign in with Apple #8570
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting! This looks great - I want to think on it for just a little bit, what I'm curious about is if there is any way to allow the new AppleCredential (with full name extras) can simply go in to the existing API, and the code can dynamically check if the fullname exists and do the correct thing in the native module
More important than that is to consult the firebase-js-sdk to see if they have any applicable APIs, I haven't checked yet but in general if they have anything that handles this, we'll follow them exactly so we maintain status as a drop-in replacement
Description
Adds the ability to set the user's full name when using Sign In With Apple.
When signing in with Apple using e.g.
react-native-apple-authentication
, Apple provides afullName
value which must be displayed in the app; furthermore, Apple provides this data only on initial sign-up and not on subsequent sign-ins.firebase-ios-sdk
supports setting that value when signing in via Firebase with an Apple credential; however,react-native-firebase
does not currently provide a way to pass thefullName
value to the underlying Firebase native code. As a result, using Sign In With Apple requires storing the user's name data in the app instead of in Firebase as with other social auth providers.This PR adds a
signInWithAppleCredential
method to theauth
module, which passes thefullName
value toappleCredentialWithIDToken
in the Firebase iOS SDK so it can be forwarded to Firebase on sign-up.Notes:
AppleAuthProvider.credential
is extended to take an optionalfullName
parametersignInWithAppleCredential
accepts a credential with or without thefullName
propertysignInWithCredential
method is unchangedThis feature is iOS only; AFAICT this functionality is already handled by the Firebase Android SDK (docs).
Related issues
Fixes #7603
Release Summary
Adds ability to set
fullName
when using Sign In With AppleChecklist
Android
iOS
Other
(macOS, web)e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
I wasn't able to add e2e tests as the Firebase emulator doesn't support social auth, but I am running it in my own app:
🔥
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter