Skip to content

FE: Wizard: Update jaas.config for GCP managed Kafka (per Google docs) #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mike-pt
Copy link

@mike-pt mike-pt commented Jun 20, 2025

Per GCP docs this is the correct JaasConfig:

https://cloud.google.com/managed-service-for-apache-kafka/docs/quickstart-java#configure_and_run_the_application

What changes did you make? (Give an overview)
Fixed the JaasConfig for GCP managed Kafka

Is there anything you'd like reviewers to focus on?
Yes Google doc states this:

bootstrap.servers=bootstrap.CLUSTER_ID.us-central1.managedkafka.PROJECT_ID.cloud.goog:9092
value.serializer=org.apache.kafka.common.serialization.StringSerializer
key.serializer=org.apache.kafka.common.serialization.StringSerializer
security.protocol=SASL_SSL
sasl.mechanism=OAUTHBEARER
sasl.login.callback.handler.class=com.google.cloud.hosted.kafka.auth.GcpLoginCallbackHandler
sasl.jaas.config=org.apache.kafka.common.security.oauthbearer.OAuthBearerLoginModule required;

If I got it correct "required" is already appended so I don't need to add it in this line, please confirm as I'm not to familiar with the code.

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)

The generated config was failing and changing this line fixed it.

NOT WORKING:

    producerProperties: {}
    properties:
      security.protocol: SASL_SSL
      sasl.mechanism: OAUTHBEARER
      sasl.jaas.config: org.apache.kafka.common.security.oauthbearer.OAuthBearerLoginModule
        required;
      sasl.client.callback.handler.class: com.google.cloud.hosted.kafka.auth.GcpLoginCallbackHandler

WORKING:

    producerProperties: {}
    properties:
      security.protocol: SASL_SSL
      sasl.mechanism: OAUTHBEARER
      sasl.jaas.config: org.apache.kafka.common.security.oauthbearer.OAuthBearerLoginModule
        required;
      sasl.client.callback.handler.class: com.google.cloud.hosted.kafka.auth.GcpLoginCallbackHandler
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

nami-cute

@mike-pt mike-pt requested a review from a team as a code owner June 20, 2025 14:06
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Jun 20, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi mike-pt! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@mike-pt mike-pt changed the title Update getJaasConfig.ts Update jaas.config for GCP managed Kafka (per Google docs) Jun 20, 2025
@Haarolean
Copy link
Member

@Muchembi hi, could you take a look please?

@Haarolean Haarolean added scope/frontend Related to frontend changes type/bug Something isn't working area/wizard UI configuration wizard issues and removed status/triage/manual Manual triage in progress labels Jul 13, 2025
@Haarolean Haarolean added this to the 1.3 milestone Jul 13, 2025
@github-project-automation github-project-automation bot moved this from Todo to PR Approved in Release 1.3 Jul 13, 2025
@Haarolean Haarolean changed the title Update jaas.config for GCP managed Kafka (per Google docs) FE: Wizard: Update jaas.config for GCP managed Kafka (per Google docs) Jul 13, 2025
@Haarolean
Copy link
Member

@mike-pt could you fix the linter issues please?

@Haarolean Haarolean modified the milestones: 1.3, 1.4 Jul 14, 2025
@Haarolean Haarolean removed this from Release 1.3 Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/wizard UI configuration wizard issues scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants