Optimize use of actions (#101)

Also squashed
* Fix actions (#102)
* Fix clang-format (#103)
* Pass CLANG_RELEASE explicitly (#104)
* Fix clang-format (#105)
* Fix clang-format (#106)
* Fix clang-format (#107)
* Fix clang-format (#108)
* Fix clang-format (#109)
* Fix clang-format (#110)
* Fix clang-format (#111)
* Fix clang-format (#112)
* Fix clang-format (#113)
* Fix clang-format (#114)
* Fix clang-format (#115)
* Fix clang-format (#116)

Persistent workflow errors were caused by actions/checkout#766
and badly configured `on:` workflow trigger

Author: Bronek

.github/workflows/build.yml

@@ -1,15 +1,16 @@
 name: build
 
 on:
-  pull_request:
-    branches:
-      - main
   push:
     branches:
-      - main
-      - 'feature/*'
-      - 'bugfix/*'
-      - 'release/*'
+      - '*'
+    paths:
+      - '.github/**'
+      - 'cmake/**'
+      - 'CMakeLists.txt'
+      - '*.cpp'
+      - '*.hpp'
+      - '*.ipp'
 
 jobs:
   build-linux:

.github/workflows/ci.yml

@@ -5,6 +5,12 @@ on:
   # https://pubs.opengroup.org/onlinepubs/9699919799/utilities/crontab.html#tag_20_25_07
   # This is meant to run at 13:17 on 11th of every month
     - cron: '17 13 11 * *'
+  push:
+    branches:
+      - main
+    paths:
+      - '.github/**'
+      - 'ci/**'
   workflow_dispatch:
 
 # Based on https://docs.docker.com/build/ci/github-actions/multi-platform/

.github/workflows/clang-format.yml

@@ -1,34 +1,46 @@
 name: clang-format
 
-on: [push, pull_request]
+on:
+  push:
+    branches:
+      - 'main'
+    paths:
+      - '.github/**'
+      - '*.cpp'
+      - '*.hpp'
+      - '*.ipp'
+      - '.clang-format'
+  pull_request:
+    branches:
+      - 'main'
 
 jobs:
   format-check:
-    runs-on: ubuntu-22.04
-    env:
-      CLANG_VERSION: 18
+    runs-on:
+      group: default
+    strategy:
+      fail-fast: false
+      matrix:
+        release:
+          - 18
+    container: libfn/ci-build-clang:${{ matrix.release }}
     steps:
     - uses: actions/checkout@v4
 
-    - name: Install clang-format
-      env:
-        DEBIAN_FRONTEND: noninteractive
+    - name: Prepare
       run: |
-        CODENAME=$( . /etc/os-release && echo $VERSION_CODENAME )
-        wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | sudo gpg --dearmor -o /etc/apt/keyrings/llvm.gpg
-        printf "%s\n%s\n" \
-          "deb [signed-by=/etc/apt/keyrings/llvm.gpg] https://apt.llvm.org/$CODENAME/ llvm-toolchain-$CODENAME-${CLANG_VERSION} main" \
-          "deb-src [signed-by=/etc/apt/keyrings/llvm.gpg] https://apt.llvm.org/$CODENAME/ llvm-toolchain-$CODENAME-${CLANG_VERSION} main" \
-          | sudo tee /etc/apt/sources.list.d/llvm.list
-        sudo apt-get update
-        sudo apt-get install -t llvm-toolchain-${CODENAME}-${CLANG_VERSION} -y --no-install-recommends clang-format-${CLANG_VERSION}
-        sudo apt-get clean
+        # Required because of https://github.com/actions/checkout/issues/766
+        git config --global --add safe.directory "${GITHUB_WORKSPACE}"
+        CLANG_RELEASE=${{ matrix.release }}
+        clang-format --version | grep -F "clang-format version ${CLANG_RELEASE}"
 
     - name: Format source files
-      run: find include tests -type f \( -name '*.cpp' -o -name '*.hpp' -o -name '*.ipp' \) -print0 | xargs -0 clang-format-${CLANG_VERSION} -i
+      run: |
+        find include tests -type f \( -name '*.cpp' -o -name '*.hpp' -o -name '*.ipp' \) -print0 | xargs -0 clang-format -i
 
     - name: Check for differences
       id: assert
+      shell: bash
       run: |
         set -o pipefail
         git diff --exit-code | tee "clang-format.patch"
@@ -51,16 +63,18 @@ jobs:
           to the formatting specified in .clang-format. That may be because
           you neglected to run 'git clang-format' or 'clang-format' before
           committing, or perhaps your version of clang-format is not compatible
-          with the one on this machine, which is:
+          with the one used in this workflow, which is:
         SUGGESTION: |
-
-          To fix it, you can do one of two things:
+          To fix it, you can do one of three things:
           1. Download and apply the patch generated as an artifact of this
              job to your repo, commit, and push.
           2. Run 'git-clang-format --extensions cpp,hpp,ipp main'
              in your repo, commit, and push.
+          3. Run 'find include tests -type f \( -name '*.cpp' -o -name '*.hpp' -o -name '*.ipp' \) -print0 | xargs -0 clang-format -i'
+             in your repo, commit, and push.
       run: |
         echo "${PREAMBLE}"
-        clang-format-${CLANG_VERSION} --version
+        clang-format --version
+        echo
         echo "${SUGGESTION}"
         exit 1

.github/workflows/coverage.yml

@@ -1,16 +1,17 @@
 name: coverage
 
 on:
-  pull_request:
-    branches:
-      - main
   push:
     branches:
-      - main
-      - 'feature/*'
-      - 'bugfix/*'
-      - 'release/*'
-  workflow_dispatch:
+      - '*'
+    paths:
+      - '.github/**'
+      - 'cmake/**'
+      - 'CMakeLists.txt'
+      - '*.cpp'
+      - '*.hpp'
+      - '*.ipp'
+      - '.codecov.yml'
 
 jobs:
   coverage:

.github/workflows/docs.yml

@@ -4,6 +4,14 @@ on:
   push:
     branches:
       - main
+    paths:
+      - '.github/**'
+      - 'cmake/**'
+      - 'CMakeLists.txt'
+      - '*.cpp'
+      - '*.hpp'
+      - '*.ipp'
+      - 'docs/**'
   workflow_dispatch:
 
 permissions:

.github/workflows/license.yml

@@ -3,10 +3,16 @@ name: license
 on:
   push:
     branches:
-      - main
-  pull_request:
-    branches:
-      - main
+      - '*'
+    paths:
+      - '.github/**'
+      - 'cmake/**'
+      - 'CMakeLists.txt'
+      - '*.cpp'
+      - '*.hpp'
+      - '*.ipp'
+      - '.fossa.yml'
+      - 'LICENSE*'
 
 jobs:
   license-check: