Skip to content

[CIR] Implement SizedTypeInterface to make isSized hookable. #1714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025

Conversation

xlauko
Copy link
Collaborator

@xlauko xlauko commented Jun 25, 2025

This resolves issues pointed out in https://github.com/llvm/llvm-project/pull/143960/files#r2164047625 of needing to update sized list of types on each new type.

@xlauko
Copy link
Collaborator Author

xlauko commented Jun 25, 2025

@xlauko xlauko marked this pull request as ready for review June 25, 2025 19:32
@xlauko xlauko force-pushed the users/xlauko/cir-sized-type-interface branch from 9136eff to 018fc54 Compare June 25, 2025 19:34
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super nice, thanks!

@xlauko
Copy link
Collaborator Author

xlauko commented Jun 27, 2025

Merge activity

  • Jun 27, 7:17 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jun 27, 7:22 AM UTC: Graphite rebased this pull request as part of a merge.
  • Jun 27, 7:24 AM UTC: @xlauko merged this pull request with Graphite.

@xlauko xlauko changed the base branch from users/xlauko/cir-cleanup-type-interfaces to graphite-base/1714 June 27, 2025 07:18
@xlauko xlauko changed the base branch from graphite-base/1714 to main June 27, 2025 07:18
This resolves issues pointed out in https://github.com/llvm/llvm-project/pull/143960/files#r2164047625  of needing to update sized list of types on each new type.
@xlauko xlauko force-pushed the users/xlauko/cir-sized-type-interface branch from 018fc54 to 5975f3b Compare June 27, 2025 07:21
@xlauko xlauko merged commit 30718ac into main Jun 27, 2025
8 of 9 checks passed
xlauko added a commit to llvm/llvm-project that referenced this pull request Jun 27, 2025
Resolves issues pointed out in https://github.com/llvm/llvm-project/pull/143960/files#r2164047625 of needing to update sized list of types on each new type.

This mirrors incubator changes from llvm/clangir#1714
xlauko added a commit to llvm/llvm-project that referenced this pull request Jun 27, 2025
Resolves issues pointed out in https://github.com/llvm/llvm-project/pull/143960/files#r2164047625 of needing to update sized list of types on each new type.

This mirrors incubator changes from llvm/clangir#1714
xlauko added a commit to llvm/llvm-project that referenced this pull request Jun 27, 2025
Resolves issues pointed out in https://github.com/llvm/llvm-project/pull/143960/files#r2164047625 of needing to update sized list of types on each new type.

This mirrors incubator changes from llvm/clangir#1714
llvm-sync bot pushed a commit to arm/arm-toolchain that referenced this pull request Jun 27, 2025
…e (#146045)

Resolves issues pointed out in https://github.com/llvm/llvm-project/pull/143960/files#r2164047625 of needing to update sized list of types on each new type.

This mirrors incubator changes from llvm/clangir#1714
rlavaee pushed a commit to rlavaee/llvm-project that referenced this pull request Jul 1, 2025
)

Resolves issues pointed out in https://github.com/llvm/llvm-project/pull/143960/files#r2164047625 of needing to update sized list of types on each new type.

This mirrors incubator changes from llvm/clangir#1714
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants