Skip to content

fix: SocietyOfMindAgent should save its response into context #6659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dason8
Copy link

@dason8 dason8 commented Jun 10, 2025

Why are these changes needed?

Currently SocietyOfMindAgent doesn't save its own response message into context, so in a multi round chat scenario, when this SocietyOfMindAgent is picked by upstream orchestrator (e.g. another GroupChat), its last response message shows in neither task messages nor inner context. This results in message lose. Then its inner team won't get same context as other agents in the upper team.

Related issue number

Checks

Copy link

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.77%. Comparing base (892492f) to head (7848659).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6659      +/-   ##
==========================================
- Coverage   79.78%   79.77%   -0.01%     
==========================================
  Files         228      228              
  Lines       17054    17057       +3     
==========================================
+ Hits        13606    13608       +2     
- Misses       3448     3449       +1     
Flag Coverage Δ
unittests 79.77% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dason8
Copy link
Author

dason8 commented Jun 10, 2025

@microsoft-github-policy-service agree company="Microsoft"

@dason8 dason8 closed this Jun 10, 2025
@dason8 dason8 reopened this Jun 10, 2025
@dason8
Copy link
Author

dason8 commented Jun 11, 2025

@ekzhu please have a review.
While I was using this SocietyOfMindAgent, I found the inner team couldn't get its last response (or a summarized version by this SocietyOfMindAgent), which not meet my expection. maybe this is bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant