Update ADO Client package to 251 (#5112)

* update to m251 version of ADO client package

* Update dependencies and react to interface changes

* Switch to BouncyCastle RSA Provider.

---------

Co-authored-by: Brian Barthel <brbarthe@microsoft.com>

Author: b-barthel

src/Agent.Sdk/Agent.Sdk.csproj

@@ -21,6 +21,7 @@
     <PackageReference Include="System.Formats.Asn1" Version="8.0.1" />
     <PackageReference Include="System.IdentityModel.Tokens.Jwt" Version="7.3.1" />
     <PackageReference Include="System.Security.Cryptography.Xml" Version="6.0.1" />
+    <PackageReference Include="System.Threading.Tasks.Dataflow" Version="8.0.0" />
     <PackageReference Include="Azure.Core" Version="1.44.1" />
   </ItemGroup>
 </Project>

src/Agent.Worker/Release/Artifacts/CustomArtifact.cs

@@ -40,7 +40,8 @@ public async Task DownloadAsync(IExecutionContext executionContext, ArtifactDefi
                     customArtifactDetails.ResultSelector,
                     customArtifactDetails.ResultTemplate,
                     customArtifactDetails.AuthorizationHeaders?.Select(header => ToAuthorizationHeader(header)).ToList(),
-                    customArtifactDetails.ArtifactVariables);
+                    customArtifactDetails.ArtifactVariables,
+                    new BouncyCastleRsaProvider());  
 
                 var artifactDownloadDetailList = new List<CustomArtifactDownloadDetails>();
                 artifactDetails.ToList().ForEach(x => artifactDownloadDetailList.Add(JToken.Parse(x).ToObject<CustomArtifactDownloadDetails>()));
@@ -123,7 +124,8 @@ private async Task DownloadArtifact(
                 {
                     IEndpointAuthorizer authorizer = SchemeBasedAuthorizerFactory.GetEndpointAuthorizer(
                         ToServiceEndpoint(customArtifactDetails.Endpoint),
-                        customArtifactDetails.AuthorizationHeaders?.Select(header => ToAuthorizationHeader(header)).ToList());
+                        customArtifactDetails.AuthorizationHeaders?.Select(header => ToAuthorizationHeader(header)).ToList(),
+                        new BouncyCastleRsaProvider()); 
 
                     using (HttpWebResponse webResponse = GetWebResponse(executionContext, artifact.DownloadUrl, authorizer))
                     {
@@ -198,7 +200,8 @@ private void EnsureVersionBelongsToLinkedDefinition(ArtifactDefinition artifactD
                     customArtifactDetails.VersionsResultSelector,
                     customArtifactDetails.VersionsResultTemplate,
                     customArtifactDetails.AuthorizationHeaders?.Select(header => ToAuthorizationHeader(header)).ToList(),
-                    customArtifactDetails.ArtifactVariables);
+                    customArtifactDetails.ArtifactVariables,
+                    new BouncyCastleRsaProvider());  
 
                 foreach (var version in versions)
                 {

src/Agent.Worker/TestResults/Parser.cs

@@ -73,9 +73,8 @@ protected override ITestResultParser GetTestResultParser(IExecutionContext execu
         {
             var traceListener = new CommandTraceListener(executionContext);
             var featureFlagService = executionContext.GetHostContext().GetService<IFeatureFlagService>();
-            var enableJunitAttachments = featureFlagService.GetFeatureFlagState(TestResultsConstants.JUnitTestCaseAttachmentsEnabled, TestResultsConstants.TCMServiceInstanceGuid);
             bool enableCustomTestFields = featureFlagService.GetFeatureFlagState(TestResultsConstants.CustomTestFieldsInPTRInputFilesEnabled, TestResultsConstants.TCMServiceInstanceGuid);
-            return new JUnitResultParser(traceListener, false, enableJunitAttachments,enableCustomTestFields);
+            return new JUnitResultParser(traceListener, false, enableCustomTestFields);
         }
     }
 

src/Common.props

@@ -11,7 +11,7 @@
     <OSPlatform>OS_UNKNOWN</OSPlatform>
     <OSArchitecture>ARCH_UNKNOWN</OSArchitecture>
     <DebugConstant></DebugConstant>
-    <VssApiVersion>0.5.247-private</VssApiVersion>
+    <VssApiVersion>0.5.251-private</VssApiVersion>
     <CodeAnalysis>$(CodeAnalysis)</CodeAnalysis>
     <InvariantGlobalization>false</InvariantGlobalization>
     <EnforceCodeStyleInBuild>false</EnforceCodeStyleInBuild>