chore: make sure _generateLocatorString does not timeout #36381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skn0tt
approved these changes
Jun 20, 2025
packages/protocol/src/protocol.yml
Outdated
| @@ -2289,6 +2289,14 @@ Frame: | |||
| returns: | |||
| element: ElementHandle | |||
|
|
|||
| generateLocatorString: | |||
| title: Generate locator | |||
There was a problem hiding this comment.
nit: if it's internal, why does it need a title?
| } | ||
| frame = frame.parentFrame(); | ||
| } | ||
| return asLocator('javascript', result.reverse().join(' >> internal:control=enter-frame >> ')); |
There was a problem hiding this comment.
is it intentional we always use javascript here, instead of sdkLanguage?
There is no reason to wait for the locator to match an element, because this method is used to convert between a locator and a preferred locator. If nothing matches, just throw an error right away.
dgozman
force-pushed
the
chore-generate-locator-no-timeout
branch
from
9736b44 to
eb893a2
Compare
Test results for "tests 1"7 flaky39453 passed, 823 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no reason to wait for the locator to match an element, because this method is used to convert between a locator and a preferred locator.
If nothing matches, just throw an error right away.