Skip to content

chore: use a single Progress instance for expect #36407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Jun 23, 2025

In the new strict progress mode, we can skip progress.race() calls and thus avoid being interrupted by the progress.

To support legacy mode, guarded by env.PLAYWRIGHT_LEGACY_TIMEOUTS, two new methods progress.legacyDisableTimeout() and progress.legacyEnableTimeout() are implemented. This will go away as soon as legacy mode is removed.

Closes #36236. References #35987.

This comment has been minimized.

@dgozman dgozman requested a review from yury-s June 23, 2025 16:33
@dgozman dgozman force-pushed the chore-expect-single-progress branch from 100bbfb to 64dacb5 Compare June 24, 2025 18:57
Copy link
Contributor

Test results for "tests 1"

3 failed
❌ [playwright-test] › runner.spec.ts:118:5 › should ignore subprocess creation error because of SIGINT @macos-latest-node18-1
❌ [playwright-test] › reporter-html.spec.ts:2890:5 › created › execSync doesnt produce a second stdout attachment @macos-latest-node18-2
❌ [webkit-library] › library/video.spec.ts:411:5 › screencast › should capture css transformation @webkit-ubuntu-22.04-node18

4 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node20-1
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39465 passed, 823 skipped
✔️✔️✔️

Merge workflow run.

@dgozman dgozman merged commit a41e16b into microsoft:main Jun 24, 2025
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants