Skip to content

chore: migrate some dispatchers from CallMetadata to Progress (part 1) #36429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 25, 2025

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Jun 24, 2025

This is a first PR in a series where we migrate all dispatchers to accept a Progress instead of a CallMetadata. The goal is to create a Progress instance in a Dispatcher based on a timeout, so that we can later abort all Progress instances when a client disconnects.

For a graduate rollout, interfaces will be marked one by one in the protocol.yml as progress: true, and this flag will be removed in the end.

Most of the server-side methods already accept a Progress, so migration is no-op. Some methods do not - in this case we assume the method is readonly, and dispatcher wraps it with progress.race().

Many server-side methods lost a timeout option in favor of a progress argument, mainly through changes to common types defined in types.ts.

Copy link
Contributor

Test results for "tests 1"

5 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node22-1
⚠️ [chromium] › headerView.spec.tsx:46:1 › should toggle filters @web-components-html-reporter
⚠️ [webkit-page] › page/elementhandle-bounding-box.spec.ts:22:3 › should work @webkit-ubuntu-22.04-node18

39467 passed, 823 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants