.Net: Shorten VectorStoreRecordDefinition option name #12085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And introduce VecroeStoreCollectionOptions
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
adamsitnik
approved these changes
May 15, 2025
|
|
||
| namespace Microsoft.Extensions.VectorData; | ||
|
|
||
| /// <summary>Abstract base class for options passed to a collection..</summary> |
There was a problem hiding this comment.
nit:
Suggested change
| /// <summary>Abstract base class for options passed to a collection..</summary> | |
| /// <summary>Abstract base class for options passed to a collection.</summary> |
…o CollectionOptions # Conflicts: # dotnet/src/Connectors/Connectors.Memory.CosmosMongoDB/CosmosMongoCollectionOptions.cs # dotnet/src/Connectors/Connectors.Memory.CosmosNoSql/CosmosNoSqlCollectionOptions.cs # dotnet/src/Connectors/Connectors.Memory.MongoDB/MongoCollectionOptions.cs
adamsitnik
force-pushed
the
CollectionOptions
branch
from
2994123 to
fd3aef3
Compare
|
I am merging on red as the 8.0 CI leg complains about a file that was modified and then reverted, which means it's some flakiness. |
adamsitnik
merged commit da66c42
into
microsoft:feature-vector-data-preb3
9 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And introduce VectorStoreCollectionOptions