.Net MEVD: Dependency Injection #12097
Conversation
…o evenMoreDi # Conflicts: # dotnet/src/VectorDataIntegrationTests/PineconeIntegrationTests/PineconeEmbeddingGenerationTests.cs
markwallace-microsoft
added
.NET
| Func<IServiceProvider, SearchIndexClient>? clientProvider = default, | ||
| Func<IServiceProvider, AzureAISearchVectorStoreOptions>? optionsProvider = default, |
There was a problem hiding this comment.
this is the most flexible overload: the user can read anything form the service provider to create SearchIndexClient and/or AzureAISearchVectorStoreOptions or do nothing and we are going to try to resolve it from the DI
| public static IServiceCollection AddAzureAISearchVectorStore( | ||
| this IServiceCollection services, | ||
| Uri endpoint, | ||
| AzureKeyCredential keyCredential, |
There was a problem hiding this comment.
Same as above, but using AzureKeyCredential rather than TokenCredential (I kept it for backward copat and ease of use)
| { | ||
| Endpoint = endpoint, | ||
| ApiKey = apiKey | ||
| }; |
There was a problem hiding this comment.
So far, we had an overload that was taking an optional HttpClient and WeaviateVectorStoreOptions:
And one of them was supposed to set the endpoint and api key. I decided to simplify it and just take the raw values here.
There was a problem hiding this comment.
I think this is OK, someone can still provide an httpclient via the clientProvider overloads.
| this IServiceCollection services, | ||
| object? serviceKey, | ||
| Uri endpoint, | ||
| string? apiKey, |
There was a problem hiding this comment.
This argument is nullable because for local testing, it can be null.
It's not optional, because I believe that it would be error prone for real-life scenarios (users missing the value in prod).
|
|
||
| namespace RedisIntegrationTests.Support; | ||
|
|
||
| internal class FakeDatabase : IDatabase |
There was a problem hiding this comment.
The Redis API does not allow to get a database without connecting to the server first. I wanted to keep those tests work no matter what, so I decided to fake the IDatabase. I had no idea that this interface implements few hundreds of methods!
There was a problem hiding this comment.
Not a big deal, but also consider using Moq
adamsitnik
merged commit 35a7beb
into
microsoft:feature-vector-data-preb3
These are all the missing connectors.
Fixes #10549