Python: Add missing index in Bedrock FunctionCallContent instantiation #12203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
the
python
github-actions
bot
changed the title
|
@ja-bot, thanks for your contribution. Please fill out the Motivation and Context / Description sections in the PR description. |
moonbox3
changed the title
Python Unit Test Overview
|
moonbox3
approved these changes
May 23, 2025
TaoChenOSU
approved these changes
May 23, 2025
eavanvalkenburg
pushed a commit
that referenced
this pull request
May 26, 2025
#12203) ### Motivation and Context The current implementation of `BedrockChatCompletion` does not correctly initialize `FunctionCallContent` instances when using the Converse Stream API, as the index is not set. As a result, when adding two consecutive `FunctionCallContent` instances that belong to different function calls, the `__add__` method does not raise a `ContentAdditionException` exception, and the parameters are incorrectly merged. ### Description This PR ensures proper initialization of the index in `FunctionCallContent` instances by using the `contentBlockIndex` value returned by the Converse Stream API in both delta and start content block messages. This prevents parameters from different function calls from being merged. See: - https://docs.aws.amazon.com/bedrock/latest/APIReference/API_runtime_ContentBlockDeltaEvent.html - https://docs.aws.amazon.com/bedrock/latest/APIReference/API_runtime_ContentBlockStartEvent.html Closes #12202 ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 Co-authored-by: Javier Cruz <me@javiercruz.com> Co-authored-by: Evan Mattson <35585003+moonbox3@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The current implementation of
BedrockChatCompletiondoes not correctly initializeFunctionCallContentinstances when using the Converse Stream API, as the index is not set. As a result, when adding two consecutiveFunctionCallContentinstances that belong to different function calls, the__add__method does not raise aContentAdditionExceptionexception, and the parameters are incorrectly merged.Description
This PR ensures proper initialization of the index in
FunctionCallContentinstances by using thecontentBlockIndexvalue returned by the Converse Stream API in both delta and start content block messages. This prevents parameters from different function calls from being merged.See:
Closes #12202
Contribution Checklist