Skip to content

refactor(NODE-3922): remove behaviour around ocsp tls options #4577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2025

Conversation

durran
Copy link
Member

@durran durran commented Jul 7, 2025

Description

Removes all behaviour associated with OCSP TLS options.

What is changing?

  • Remove behaviour around tlsDisableOCSPEndpointCheck and tlsDisableCertificateRevocationCheck
  • Update comment on skipped URL options tests

Note - no deprecations were needed as we didn't specify these options in our client options nor in the connection string parser. They were never exposed anywhere.

Is there new documentation needed for these changes?

None. These options are not documented in the MongoDB Nodejs Manual or our API docs.

What is the motivation for this change?

NODE-3922

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran marked this pull request as ready for review July 7, 2025 19:22
@durran durran requested a review from a team as a code owner July 7, 2025 19:22
@durran durran changed the title feat(NODE-3922): remove behaviour around ocsp tls options refactor(NODE-3922): remove behaviour around ocsp tls options Jul 8, 2025
@durran durran requested a review from dariakp July 9, 2025 14:18
@dariakp dariakp self-assigned this Jul 9, 2025
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jul 9, 2025
@dariakp dariakp merged commit a09212a into main Jul 9, 2025
31 checks passed
@dariakp dariakp deleted the NODE-3922 branch July 9, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants