Skip to content

TSL: Fix outgoingLight redeclaration #31266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2025
Merged

TSL: Fix outgoingLight redeclaration #31266

merged 1 commit into from
Jun 15, 2025

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jun 15, 2025

Description

.toVar() adds the node to the current Stack, if this is called improperly it can cause redeclaration, as was the case when the class LightsNode was declared.

@sunag sunag added this to the r178 milestone Jun 15, 2025
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 337.54
78.73
337.54
78.73
+0 B
+0 B
WebGPU 553.97
153.41
554.01
153.42
+41 B
+7 B
WebGPU Nodes 553.32
153.26
553.36
153.26
+41 B
+7 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 468.74
113.38
468.74
113.38
+0 B
+0 B
WebGPU 629.59
170.31
629.63
170.32
+41 B
+7 B
WebGPU Nodes 584.44
159.66
584.48
159.67
+41 B
+7 B

@sunag sunag marked this pull request as ready for review June 15, 2025 03:14
@sunag sunag merged commit 26a2768 into mrdoob:dev Jun 15, 2025
25 of 28 checks passed
@sunag sunag deleted the dev-lightsnode branch June 15, 2025 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant