-
-
Notifications
You must be signed in to change notification settings - Fork 35.9k
TSL: Remove transformed*
prefix
#31271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
This was referenced Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #31177, #31260, #30849
Description
Removing the
transformed
prefix from normals also simplifies the shader creation process, making it less confusing.For those who need normals without the fine surface transformations (fragment), a suffix called
Geometry
has been added, such asnormalViewGeometry
.With the implementation of
namespace
, thenormalView
node, for example, will return the same asnormalViewGeometry
if used inside thematerial.normalNode
input, and if used outside, it will use the final calculation.This is also more in line with the strategy of moving the vertex calculations from
skinning
andmorph
tocompute()
and leaving it with the fewest possible modifications, perhaps none for the target developer.