Skip to content

WebGPURenderer: Restore isSampledTexture3D binding check #31327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2025

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jun 28, 2025

Related issue: #31175

Description

Restore isSampledTexture3D binding check and fix webgpu_postprocessing_3dlut example and Data3DTexture.

@sunag sunag added this to the r178 milestone Jun 28, 2025
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 337.71
78.77
337.71
78.77
+0 B
+0 B
WebGPU 557.9
154.38
557.91
154.39
+5 B
+8 B
WebGPU Nodes 556.83
154.17
556.83
154.18
+5 B
+9 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 468.94
113.46
468.94
113.46
+0 B
+0 B
WebGPU 633.27
171.37
633.27
171.38
+5 B
+7 B
WebGPU Nodes 588.32
160.71
588.33
160.72
+5 B
+8 B

@sunag sunag marked this pull request as ready for review June 28, 2025 21:22
@sunag sunag merged commit acd3e4a into mrdoob:dev Jun 28, 2025
12 checks passed
@sunag sunag deleted the dev-fix-binding-3d-texture branch June 28, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant