tests: Mark the tests that don't need to downoad test files with the …

[LocutusOfBorg]

This way in Debian and Ubuntu we can easily skip them when no internet is available

[coveralls]

coverage: 99.186%. remained the same
when pulling eedb7a8 on LocutusOfBorg:offline-tests
into 8215dba on nlohmann:develop.

[gregmarr]

Is it better to mark the ones that don't need to download things, or the ones that do?

[nlohmann]

From the README:

Note that during the ctest stage, several JSON test files are downloaded from an external repository. If policies forbid downloading artifacts during testing, you can download the files yourself and pass the directory with the test files via -DJSON_TestDataDirectory=path to CMake. Then, no Internet connectivity is required. See issue #2189 for more information.

Would using JSON_TestDataDirectory be an option?

[github-actions]

This pull request has been marked as stale because it has had no activity for 30 days. While we won’t close it automatically, we encourage you to update or comment if it is still relevant. Keeping pull requests active and up-to-date helps us review and merge changes more efficiently. Thank you for your contributions!

[LocutusOfBorg]

Can we merge and improve later maybe?

[nlohmann]

Can you check if JSON_TestDataDirectory works for you?

[LocutusOfBorg]

Hello, so some questions:

1. why is this test data on different repo?
   (I presume due to $SIZE)
2. adding it as external tarball will increase the code complexity, forget to update, make source download heavier, as well as having it as git submodule.
   I'll think a little bit about it, but maybe instead of having a 100MB tarball additional, we can better exclude some tests...

[LocutusOfBorg]

ok we can package the json test data separately in Debian as standalone project, this will also help your ci test environment (if you want to use apt)
Something like this looks working, but I now have errors in cmake_fetch and fetch2 tests (we need to disable them too)

--- nlohmann-json3-3.11.3.orig/cmake/download_test_data.cmake
+++ nlohmann-json3-3.11.3/cmake/download_test_data.cmake
@@ -1,6 +1,12 @@
 set(JSON_TEST_DATA_URL     https://github.com/nlohmann/json_test_data)
 set(JSON_TEST_DATA_VERSION 3.1.0)
 
+set(JSON_TEST_DATA_DIR /usr/share/json_test_data-${JSON_TEST_DATA_VERSION})
+
+if(EXISTS ${JSON_TEST_DATA_DIR})
+  set(JSON_TestDataDirectory ${JSON_TEST_DATA_DIR})
+endif()
+
 # if variable is set, use test data from given directory rather than downloading them
 if(JSON_TestDataDirectory)
     message(STATUS "Using test data in ${JSON_TestDataDirectory}.")

[LocutusOfBorg]

 88 - cmake_fetch_content_configure (Failed)            git_required not_reproducible
 89 - cmake_fetch_content_build (Not Run)               git_required not_reproducible
 90 - cmake_fetch_content2_configure (Failed)           git_required not_reproducible
 91 - cmake_fetch_content2_build (Not Run)              git_required not_reproducible

[nlohmann]

1. why is this test data on different repo?
   (I presume due to $SIZE)

Exactly.

[github-actions]

This pull request has been marked as stale because it has had no activity for 30 days. While we won’t close it automatically, we encourage you to update or comment if it is still relevant. Keeping pull requests active and up-to-date helps us review and merge changes more efficiently. Thank you for your contributions!