Skip to content

added request error callback support #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Conversation

gnibeda
Copy link

@gnibeda gnibeda commented Nov 12, 2020

No description provided.

@gnibeda gnibeda merged commit 1fc6df0 into master Nov 12, 2020
@@ -73,6 +73,11 @@ DataSource.prototype._post = function (url, data, callback) {
}
})());
} else if (xhr.readyState === 4 && xhr.status !== 200) {
handler = self.LPT.CONFIG.triggers["requestError"];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there's already "responseHandler": thus, no need in "requestError"

@nikitaeverywhere
Copy link
Member

You can extend responseHandler with the error message instead (also de-HTML this message)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants