Skip to content

DOC: Pin numpydoc=1.8.0 #61725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

fangchenli
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@fangchenli fangchenli added Docs Dependencies Required and optional dependencies labels Jun 27, 2025
@mroeschke
Copy link
Member

Is there a way for us to replace our numpydoc usage so we could use a numpydoc>=1.9.0 instead?

@fangchenli
Copy link
Member Author

Is there a way for us to replace our numpydoc usage so we could use a numpydoc>=1.9.0 instead?

It probably needs to be fixed from the numpydoc side. We could pin it for now to make the CI green.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to get this merged for now, and check later if we can require the version after the bug is fixed.

@mroeschke
Copy link
Member

Thanks @fangchenli, but I just merged #61744 which allow us to get around the error (skipping validation for objects that don't have docstrings which is probably the right thing to do).

Going to close since we don't need to pin numpydoc anymore

@mroeschke mroeschke closed this Jun 30, 2025
@fangchenli fangchenli deleted the fix-docstring-validation branch June 30, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Required and optional dependencies Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants