Skip to content

feat: Try multiple hash funcs files.get and files.put #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 9, 2025

Conversation

mrkbac
Copy link
Contributor

@mrkbac mrkbac commented Jun 22, 2025

Support more hash functions for files.put, files.get, on machine I'm working with does not support the sha1 commands, So with this PR md5, sha1,sha264 are tries in this order

Maybe this should be configurable?

  • Pull request is based on the default branch (3.x at this time)
  • Pull request includes tests for any new/updated operations/facts
  • Pull request includes documentation for any new/updated operations/facts
  • Tests pass (see scripts/dev-test.sh)
  • Type checking & code style passes (see scripts/dev-lint.sh)

Copy link
Member

@Fizzadar Fizzadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is awesome stuff @mrkbac! Two minor comments to addres 🙏

@Fizzadar Fizzadar force-pushed the file-support-more-hash branch from 7b5b758 to c1d0276 Compare July 9, 2025 13:01
Copy link
Member

@Fizzadar Fizzadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this, @mrkbac, looks great! I made a mess by pushing my own md5/sha256 changes up yesterday so fixed that up ready to merge, apologies!

@Fizzadar Fizzadar merged commit 01ccda0 into pyinfra-dev:3.x Jul 9, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants