Use errors.Is for error comparison in assertError helper #827
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are you trying to solve?
The current
assertError
helper function in the Maps chapter uses direct error comparison (!=
) which doesn't handle wrapped errors correctly. This could teach readers a pattern that might not work in real-world scenarios where error wrapping is common.What changes are you making?
Updated the
assertError
helper function to useerrors.Is
instead of direct comparison. This better reflects modern Go error handling practices and will work correctly with wrapped errors.Example
Before:
After:
Additional context
errors.Is was introduced in Go 1.13 and is now the recommended way to compare errors. This change helps teach more robust error handling patterns.
If this change is approved, I will create a corresponding update to the README file to explain why
errors.Is
is preferred over direct comparison and provide examples of when it's particularly useful (such as with wrapped errors).