-
Notifications
You must be signed in to change notification settings - Fork 13.5k
allow clippy manual ascii check for definitions of them #143367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
efba40e
to
91df163
Compare
This comment has been minimized.
This comment has been minimized.
91df163
to
10c5e5b
Compare
This comment has been minimized.
This comment has been minimized.
10c5e5b
to
480e574
Compare
Is clippy run on the standard library? I didn't think that was the case. |
Currently clippy gives a lot of warnings, making it pretty useless, so I'm trying to change that. |
Is that something the libs team has approved? While a single PR isn't much, a series of them is. |
I haven't asked for specific approval for this idea. If you think that I should, then I'm happy to do that. |
I think that would be best to avoid doing something the team doesn't ultimately care for. A quick search shows that you've already opened a dozen PRs, which is exactly what I expected. If the team doesn't want to enable clippy in the end, then some of them (like this) wouldn't serve a direct purpose. |
No description provided.