Skip to content

Various refactorings to the metadata loader #143369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 3, 2025
Merged

Various refactorings to the metadata loader #143369

merged 4 commits into from
Jul 3, 2025

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Jul 3, 2025

No description provided.

bjorn3 added 4 commits July 3, 2025 11:52
@bjorn3
Deduplicate getting the path of a lib candidate
121dac5
@bjorn3
Pass CrateRejections separately from CrateLocator
8763305 
This allows all CrateLocator methods to take &self.
@bjorn3
Have a separate code path for -Zdual-proc-macro
57d6c1b 
This makes it clearer when the locator and when crate_rejections is updated
@bjorn3
Make most CrateLocator fields private
47caa0a 
This ensures they don't get out of sync
@rustbot
Copy link
Collaborator

rustbot commented Jul 3, 2025

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 3, 2025
@bjorn3
Copy link
Member Author

bjorn3 commented Jul 3, 2025 •
edited
Loading

Best reviewed commit by commit.

@lcnr
Copy link
Contributor

lcnr commented Jul 3, 2025

r=me after CI

@bjorn3
Copy link
Member Author

bjorn3 commented Jul 3, 2025

@bors r=lcnr

@bors
Copy link
Collaborator

bors commented Jul 3, 2025

📌 Commit 47caa0a has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2025
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jul 3, 2025
Merged
bors added a commit that referenced this pull request Jul 3, 2025
@bors
Auto merge of #143390 - GuillaumeGomez:rollup-2avj41s, r=GuillaumeGomez
da58c05 
Rollup of 5 pull requests

Successful merges:

 - #141831 (rustdoc: fix attrs of locally reexported foreign items)
 - #143364 (don't include `.md` in title)
 - #143369 (Various refactorings to the metadata loader)
 - #143379 (Post {beta,stable}-accepted notifications to compiler/bootstrap backport zulip channels on `{beta,stable}-accepted` label application)
 - #143384 (Update browser-ui-test version to `0.21.1`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 62a7fb0 into rust-lang:master Jul 3, 2025
10 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 3, 2025
rust-timer added a commit that referenced this pull request Jul 3, 2025
@rust-timer
Unrolled build for #143369
394b3f8 
Rollup merge of #143369 - bjorn3:cleanup_metadata_loading, r=lcnr

Various refactorings to the metadata loader
@bjorn3 bjorn3 deleted the cleanup_metadata_loading branch July 4, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
4 participants
@bjorn3 @rustbot @lcnr @bors