-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Post {beta,stable}-accepted notifications to compiler/bootstrap backport zulip channels on {beta,stable}-accepted
label application
#143379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add some dividing sections, as it was hard to quickly identify which section is which.
|
Realized that this wasn't configured for both compiler/bootstrap when wondering why #t-infra/bootstrap/backports > #142928: beta-nominated didn't have a beta-accepted notification posted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks. I didn't check that the configuration was incomplete.
Neither did I when I copy pasted the compiler config for bootstrap 😆 |
@bors r+ rollup |
Rollup of 5 pull requests Successful merges: - #141831 (rustdoc: fix attrs of locally reexported foreign items) - #143364 (don't include `.md` in title) - #143369 (Various refactorings to the metadata loader) - #143379 (Post {beta,stable}-accepted notifications to compiler/bootstrap backport zulip channels on `{beta,stable}-accepted` label application) - #143384 (Update browser-ui-test version to `0.21.1`) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #143379 - jieyouxu:backport-accepted, r=apiraino Post {beta,stable}-accepted notifications to compiler/bootstrap backport zulip channels on `{beta,stable}-accepted` label application The first commit slightly reorganizes `triagebot.toml` (no functional changes) with some dividing sections, because I found it hard to find the actual sections. The second and third commit configures triagebot to post > PR #`{number}` has been **accepted** for **{beta,stable}** backport. to compiler/bootstrap backport threads respectively, when https://github.com/rust-lang/rust/labels/beta-accepted and https://github.com/rust-lang/rust/labels/stable-accepted labels are applied. Best reviewed commit-by-commit. cc `@Kobzol` r? `@apiraino`
The first commit slightly reorganizes
triagebot.toml
(no functional changes) with some dividing sections, because I found it hard to find the actual sections.The second and third commit configures triagebot to post
to compiler/bootstrap backport threads respectively, when beta-acceptedAccepted for backporting to the compiler in the beta channel.
and
stable-accepted
Accepted for backporting to the compiler in the stable channel.
labels are applied.
Best reviewed commit-by-commit.
cc @Kobzol
r? @apiraino