Skip to content

Replace Object.assign() with Object spread syntax (...) #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions README.md
Original file line number Diff line number Diff line change
@@ -509,7 +509,7 @@ function showEmployeeList(employees) {

**[⬆ back to top](#table-of-contents)**

### Set default objects with Object.assign
### Set default objects with Object spread syntax (...)

**Bad:**

@@ -543,16 +543,17 @@ const menuConfig = {
};

function createMenu(config) {
let finalConfig = Object.assign(
{
title: "Foo",
body: "Bar",
buttonText: "Baz",
cancellable: true
},
config
);
return finalConfig
const defaultConfig = {
title: "Foo",
body: "Bar",
buttonText: "Baz",
cancellable: true,
};
const finalConfig = {
...defaultConfig,
...config,
};
return finalConfig;
// config now equals: {title: "Order", body: "Bar", buttonText: "Send", cancellable: true}
// ...
}