Unintended SafeValue Error

[JasonH53]

Test case is expected to emit output with --Ysafe-init-global, but it emits a safe-value internal error. It is temporarily placed in the pos-tasty folder.

[JasonH53]

signed CLA

[liufengyun]

I was thinking, why not always dispatch to call if the symbol is a method.

If that is the case, maybe it's better to fix the extractor Call:

scala3/compiler/src/dotty/tools/dotc/transform/init/Util.scala

Lines 44 to 65 in 35c2ef3

	def unapply(tree: Tree)(using Context): Option[(Tree, List[List[Arg]])] =
	tree match
	case Apply(fn, args) =>
	val argTps = fn.tpe.widen match
	case mt: MethodType => mt.paramInfos
	if (args.size != argTps.size)
	report.warning("[Internal error] Number of arguments do not match number of argument types in " + tree.symbol.name)
	val normArgs: List[Arg] = args.zip(argTps).map {
	case (arg, _: ExprType) => ByNameArg(arg)
	case (arg, _) => arg
	}
	unapply(fn) match
	case Some((ref, args0)) => Some((ref, args0 :+ normArgs))
	case None => None
	case TypeApply(fn, targs) =>
	unapply(fn)
	case ref: RefTree if ref.tpe.widenSingleton.isInstanceOf[MethodicType] =>
	Some((ref, Nil))
	case _ => None

[JasonH53]

Great idea! Would that mean that we should change Call:

 case ref: RefTree if ref.symbol.is(Flags.Method) && ref.tpe.widenSingleton.isInstanceOf[MethodicType] =>
        Some((ref, Nil))

and leaving the def cases unchanged?

[liufengyun]

We can try just keep if ref.symbol.is(Flags.Method).