Add support for multiple TaskDecorator beans #45302
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Previously, only a single TaskDecorator bean, if unique, was applied to the auto-configured TaskExecutor or Scheduler. With this change, if multiple TaskDecorator beans are defined, they will be combined into a `CompositeTaskDecorator` and applied accordingly. Signed-off-by: Dmytro Nosan <dimanosan@gmail.com>
nosan
commented
Apr 26, 2025
| @@ -451,6 +485,10 @@ void shouldNotAliasApplicationTaskExecutorWhenBootstrapExecutorAliasIsDefined() | |||
| }); | |||
| } | |||
|
|
|||
| private TaskDecorator createTaskDecorator() { | |||
| return (runnable) -> runnable; | |||
There was a problem hiding this comment.
A custom implementation instead of Mockito.mock(TaskDecorator.class) to avoid this exception
Exception in thread "scheduling-1" java.lang.NullPointerException: Cannot invoke "java.lang.Runnable.run()" because "this.decoratedRunnable" is null
at org.springframework.scheduling.concurrent.ThreadPoolTaskScheduler$DelegatingRunnableScheduledFuture.run(ThreadPoolTaskScheduler.java:508)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:840)
snicoll
added
type: enhancement
wilkinsona
pushed a commit
that referenced
this pull request
Jul 2, 2025
Previously, only a single TaskDecorator bean, if unique, was applied to the auto-configured TaskExecutor or Scheduler. With this change, if multiple TaskDecorator beans are defined, they will be combined into a `CompositeTaskDecorator` and applied accordingly. Signed-off-by: Dmytro Nosan <dimanosan@gmail.com> See gh-45302
wilkinsona
added a commit
that referenced
this pull request
Jul 2, 2025
|
Thanks very much, @nosan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #45295