suite: faster methods filtering (internal refactor) #1758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolmen
added
pkg-suite
dolmen
changed the title
dolmen
changed the title
ccoVeille
reviewed
May 31, 2025
dolmen
force-pushed
the
dolmen/suite-faster-method-filtering
branch
from
baeed2b to
6ce76f9
Compare
Use strings.HasPrefix instead of a /^Test/ regexp (compiled on every call).
Refactor filtering of methods in suite.Run: the regexp given via -testify.m flag is compiled just once, out of the loop.
dolmen
force-pushed
the
dolmen/suite-faster-method-filtering
branch
from
6ce76f9 to
b2caf47
Compare
ccoVeille
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In package
suite, speed-up the filtering of methods (-testify.mflag) by compiling the regexp just once instead of when checking each method.Changes
strings.HasPrefixinstead of a^Testregexp compiled for every checked method-testify.mis given: compile the regexp onceMotivation
Runtime speed!
Related issues
N/A