WIP: Improve settingsForProductReferenceTarget
#32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we only consider direct dependencies when looking up configured targets in the product plan, leading to use of the fallback in more cases than necessary. I am intentionally keeping the `.only` here since we don't have a great way of deciding the correct target if there's more than one, though maybe we should just bias towards the platform of `clientTarget` since the fallback will do that anyway? Another thing I am not sure about is what impact this will have on perf since computing the transitive closure will definitely be a heavier operation than what we are currently doing. I'd also like to add a test which exposes a case where using the primary case instead of the fallback is beneficial.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we only consider direct dependencies when looking up configured targets in the product plan, leading to use of the fallback in more cases than necessary. I am intentionally keeping the
.onlyhere since we don't have a great way of deciding the correct target if there's more than one, though maybe we should just bias towards the platform ofclientTargetsince the fallback will do that anyway?Another thing I am not sure about is what impact this will have on perf since computing the transitive closure will definitely be a heavier operation than what we are currently doing.
I'd also like to add a test which exposes a case where using the primary case instead of the fallback is beneficial.