Skip to content

Prevent subsequent calls to updateEmbeds when there are no embeds #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 12, 2025

Conversation

driesvints
Copy link
Contributor

@driesvints driesvints commented May 25, 2025

While working on uncovering #1078 I noticed that calls were made to updateEmbeds even if there aren't any embeds.

Prevent subsequent calls if there's no embeds.
@driesvints driesvints marked this pull request as ready for review May 25, 2025 19:15
@driesvints driesvints changed the title Update EmbedProcessor.php Prevent subsequent calls to updateEmbeds when there are no embeds. May 25, 2025
@driesvints driesvints changed the title Prevent subsequent calls to updateEmbeds when there are no embeds. Prevent subsequent calls to updateEmbeds when there are no embeds May 25, 2025
Copy link
Member

@colinodell colinodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and contributing this!

@colinodell colinodell merged commit b7b87c4 into thephpleague:2.7 Jun 12, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants